Improve query/reply perf #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'enhancement', 'bug', 'documentation', 'dependencies', 'breaking-change', 'internal', 'new feature'} |
sashacmc
reviewed
Nov 12, 2024
jean-roland
force-pushed
the
ft_query_reply_perf
branch
from
00acb7e
to
63123b9
Compare
sashacmc
approved these changes
Nov 13, 2024
jean-roland
added a commit
to jean-roland/zenoh-pico
that referenced
this pull request
Nov 13, 2024
* fix: remove superfluous rc init * feat: lazify svec release * refactor: rename slice_empty as slice_null * feat: rework svec expand * refactor: z_bytes_append_slice * feat: lazify arc slice * feat: improve stirng/slice move * feat: lazify sample timestamp set * feat: add non-reader decode functions * feat: remove superfluous keyexpr clear * feat: add bytes alias arc * feat: add rx pool size config option * feat: use transport arc slice pool for payload decode * feat: n msg svec is now a transport resource pool * fix: add offset to svec init * feat: make svec use elem f a per call arg * feat: skip ke suffix check * fix: arc pool * feat: improve sub perf and readability * feat: add z_string_alias_slice function * feat: align queryable with subscription * feat: align reply with sub & queryables * feat: nothing to clear in frame * fix: reply clean up * feat: streamline replies * feat: query is not a rc and store a session rc * fix: ci issues * fix: attachment examples * fix: keyexpr equals * fix: flaky test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last perf PR before 1.1 merge into main. Include:
For every message of a frame we used to allocate and free a network message and a
Vec<Arc<Subslice>>of size 1 for every payload. Instead of doing that, a transport now has aVec<network message>and aVec<Arc<Subslice>>that can be reused from a frame to another to avoid the time lost in allocating/freeing and the fragmentation.Svec allows to chose if we want to use the element function when we copy/move per call instead of at define.
Query, reply and samples functions take ownership of the decoded data and free them systematically.
Queryable have a cache system similar to subscriber (that will also be moved to a lru cache in the future).
Queries are not longer an rc and holds a reference to the session instead of a weak.